Add Pi types for iterative sets#1306
Open
flgrubm wants to merge 11 commits into
Open
Conversation
…ossy-unification`
…--lossy-unification` [skip ci]
… a (reasonably) finite time; cleanup needed
…easonably) finite time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds codes for Pi types for iterative sets. They were originally part of #1300, but I separated them out due to termination issues with type checking for that module. This pull request also cleans up the proofs in
Cubical.Data.IterativeSets.UnorderedPairandCubical.Data.IterativeSets.OrderedPair(which...Pidepends on) to make the code faster and easier to read.The current performance situation (on my machine) is als follows:
UnorderedPair.Base: typechecks almost instantly even without--lossy-unificationOrderedPair: needs--lossy-unification, then typechecks almost instantlyPi: needs--lossy-unification, then typechecks within a couple of seconds